[Bug 752085] dashdemux: revert changes introduced in fix for bug 751850

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752085

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Florin Apostol from comment #4)
> the new problem is in commit 07d27d906af32c82b0d7460ef63aabf073906df0
> mpdparser: Fix off-by-one in has-next-segment calculation
> 
> Why did you made that change?

See the related adaptivedemux change. Consider the following case:
- we're currently downloading segment 304 of 305
- downloading fails
- has_next_segment() still returns TRUE because 304 < 305

but: 304 is the last segment of the stream. It has no next segment anymore.

> It was strange that the developer choose to keep the index of the next
> segment, instead of the natural way of keeping the index of the current
> segment. It confused me when trying to understand what this index really
> points to and when it is valid and when not.
> 
> Please revert commit 07d27d906af32c82b0d7460ef63aabf073906df0

I think your understanding of it is not correct, it's at least not what happens
in adaptivedemux. The segment index is the index of the current segment we're
downloading until that download is finished. Only once the download is finished
it will be incremented with advance_segment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.