[Bug 752085] dashdemux: revert changes introduced in fix for bug 751850

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752085

--- Comment #14 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Sebastian Dröge (slomo) from comment #12)
> I don't think I agree here. Do you see an actual problem, if so which?
> 
> All uses of segment_index seem to be for the "current" segment, that is the
> one that is currently going to be downloaded. Basically the "current"
> position. And that's also how this information is used inside adaptivedemux.
> 
That's correct. The problem is that dashdemux calls this current segment "next
segment". So functions are named get_next_fragment,
gst_mpd_client_has_next_segment, etc. They all use the current value of
segment_index, so they are referring to your current segment, but the function
names contain a misleading "next" word in them. Thy should be called
has_current_segment, get_current_fragment, etc.

If you accept this, then you realize there is no function to see if there is a
segment beyond the current one. The has_next_segment is an unfortunate naming
for get_current_segment and there is no proper has_next_segment function

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.