[Bug 752116] adapter: failure of gst_adapter_get_(buffer_)list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752116

--- Comment #9 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 307084:
 --> (https://bugzilla.gnome.org/review?bug=752116&attachment=307084)

::: libs/gst/base/gstadapter.c
@@ +1108,3 @@
     hsize = MIN (nbytes, cur_size - skip);

+    if (skip == 0 && cur_size == hsize) {

I think you wan to gst_buffer_ref the buffer ic cur_size <= to hsize, otherwise
it will create a new buffer to every buffer except the last one.

@@ +1232,3 @@
     hsize = MIN (nbytes, cur_size - skip);

+    if (skip == 0 && cur_size == hsize) {

same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.