[Bug 752186] gst-libav: avaudenc: fails at 2 channel wmav2 file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752186

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307163|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 307163:
 --> (https://bugzilla.gnome.org/review?bug=752186&attachment=307163)

::: ext/libav/gstavauddec.c
@@ +381,3 @@
   if (channels == 0)
+    /* ffmpeg might not have default channel layout for some channels */
+    channels = context->channels;

The problem here is that in theory the number of channels in the context might
be different than the number of channels in the current output frame. Like what
we had in the video decoder before, which then caused crashes.

The context values are always for the latest input data, which might be newer
values than what you currently get as output from the decoder.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.