[Bug 752362] taglist: update merge logic when one of the input is empty

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752362

--- Comment #4 from Vineeth <vineeth.tm at samsung.com> ---
I think, it is not the job of gsttaglist, to create a new empty list whenever
the caller passes NULL list, just to accommodate these two modes.
If the callers needs to handle, GST_TAG_MERGE_KEEP_ALL and
GST_TAG_MERGE_REPLACE_ALL, then caller should make sure there is no NULL list
being passed by creating a new empty list and passing it on.

This is what is happening right now.
gst_tag_list_merge(list, NULL, GST_TAG_MERGE_REPLACE_ALL);
list2 = gst_tag_list_new_empty ();
gst_tag_list_insert(list, list2, GST_TAG_MERGE_REPLACE_ALL);

If the caller expects gsttaglist to create a new empty list, even when NULL
list is being passed as input, then it might as well expect gst_tag_list_insert
to do the same... something like the below statement to work.
gst_tag_list_insert(list, NULL, GST_TAG_MERGE_REPLACE_ALL);
so in this case, since replace all is being set, then the list will be replaced
with NULL..

IMO, merge should work only when there are two lists to merge, similar to how
merge works in general...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.