[Bug 751104] make Gtk sinks usable from gst-launch

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751104

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307501|none                        |reviewed
             status|                            |

--- Comment #13 from Xavier Claessens <xclaesse at gmail.com> ---
Review of attachment 307501:
 --> (https://bugzilla.gnome.org/review?bug=751104&attachment=307501)

::: ext/gtk/gstgtkglsink.c
@@ +441,3 @@
 {
   GstGtkGLSink *gtk_sink;
+  GstFlowReturn ret = GST_FLOW_OK;

You don't need this var anymore

::: ext/gtk/gtkgstglwidget.c
@@ +613,3 @@

+  g_main_context_invoke_full (main_context, G_PRIORITY_DEFAULT,
+      (GSourceFunc) _queue_draw, g_object_ref (widget), g_object_unref);

Thinking again about this, it would be simpler to use g_idle_add() here, and it
has the advantage of retuning a source ID that you can g_source_remove() in
dispose. You can then even remove your destroyed boolean. And that also solves
my concern about the g_object_unref as GDestroyNotify that could be the last
unref of the widget and I'm not 100% sure it's guaranteed to happen in GTK
thread (it probably is, I guess...).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.