[Bug 739472] multifilesrc: Lost the ability to start at a different frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739472

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307052|none                        |reviewed
             status|                            |

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 307052:
 --> (https://bugzilla.gnome.org/review?bug=739472&attachment=307052)

::: gst/multifile/gstmultifilesrc.c
@@ +303,3 @@
     case PROP_INDEX:
       src->index = g_value_get_int (value);
+      if (GST_STATE (src) == GST_STATE_NULL) {

You'd would need the object lock here.

@@ +305,3 @@
+      if (GST_STATE (src) == GST_STATE_NULL) {
+        if (src->index > src->start_index)
+          src->start_index = src->index;

All this is very ambiguous. In Vincent patch, we'd have a initial see to index,
while the stream period is still from start to stop. So if you see to zero, you
seek to start. In your patch we have a different behaviour, seeking to zero
would seek to what index was initially. In fact, start_index is lost.

I do think what Vincent patch does is more correct, Has it honor all
properties.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.