[Bug 752618] v4l2bufferpool: Set timestamp when queue buffer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 20 06:49:22 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=752618

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307747|none                        |reviewed
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 307747:
 --> (https://bugzilla.gnome.org/review?bug=752618&attachment=307747)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +150,3 @@
   }

+  gst_buffer_copy_into (dest, src, GST_BUFFER_COPY_TIMESTAMPS, 0, -1);

We should also copy the flags. At least GST_BUFFER_FLAG_DELTA_UNIT could be
useful eventually, but other could be too. It is also armless to keep them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list