[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 20 08:12:25 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=705991

--- Comment #134 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Alright, pushed this now:

commit b4fe1b516be609c1998ded211764c874569a3422
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Sat Jul 18 21:18:23 2015 +0100

    adaptivedemux: minor clean-up

    No need for a foreach callback function that's just a few
    lines of code and is only used once, just do the event
    pushing inline.

    https://bugzilla.gnome.org/show_bug.cgi?id=705991

commit 71a1e3669a743daa5affbdb6d73f6949d4965818
Author: Alex Ashley <bugzilla at ashley-family.net>
Date:   Fri Feb 6 13:22:14 2015 +0000

    dashdemux: add support for generating Protection events from
ContentProtection elements

    If a ContentProtection element is present in an AdaptationSet element,
    send Protection events on the source pad, so that qtdemux can use this
    information to correctly generate its source caps for DASH CENC
    encrypted streams.

    This allows qtdemux to support CENC encrypted DASH streams where the
    content protection specific information is carried in the MPD file
    rather than in pssh boxes in the initialisation segments.

    This commit adds a new function to the adaptivedemux base class to allow
    a GstEvent to be queued for a stream. The queue of events are sent the
    next time a buffer is pushed for that stream.

    https://bugzilla.gnome.org/show_bug.cgi?id=705991

which is basically your patch with minor formatting/indentation changes, and
_add_event() renamed to _queue_event() which seems more appropriate. I merged
your updates into a modified version of your previous patch, hopefully I didn't
mess up somewhere. Please test.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list