[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306517|none                        |reviewed
             status|                            |

--- Comment #54 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 306517:
 --> (https://bugzilla.gnome.org/review?bug=745107&attachment=306517)

::: ext/gl/gstglcolorconvertelement.c
@@ +54,2 @@
 static GstStaticPadTemplate gst_gl_color_convert_element_src_pad_template =
+    GST_STATIC_PAD_TEMPLATE ("src",

Was obviously more readable before, I support you could use INDENT-OFF mark.

::: gst-libs/gst/gl/gstglupload.c
@@ +967,2 @@
   for (i = 0; i < G_N_ELEMENTS (upload_methods); i++) {
+    tmp2 = upload_methods[i]->transform_caps (context, direction, caps);

You could have kept the tmp2 in the loop scope. I can't see any rational to
change this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.