[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

--- Comment #71 from Matthew Waters <ystreet00 at gmail.com> ---
(In reply to Lubosz Sarnecki from comment #69)
> 1. The lag is due to the nature of the poorly performing allocation query
> propagation. It is a known issue. It worked very fluently with a custom
> upstream event, but the decision was to fix the performance of the
> allocation query.

Ok

> 2. Which naming do you suggest?

Pick one, but be consistent.  Moot point with 3).

> 3. Why put 2 classes in 1 file?

As I see the code use, the compositor directs the usage of the composition
objects that is entirely internal to the compositor's operation and doesn't
need to be public API.  Therefore, the composition object can go into
gstgloverlaycompositor.c and not be exposed as public API removing the need for
gstglcompositionoverlay.c/h to exist.

> 4. This would mean more duplication of glimagesink code, but it is doable.

The only thing you're not doing on top of glimagesink is creating/setting up
the shader.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.