[Bug 752421] matroskademux: SRT subtitles with markup are displayed with a trailing asterisk

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752421

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Third time lucky, hopefully:

commit c1382e97fa48f299895dd641df75b4e2ca588f31
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Jul 16 18:09:30 2015 +0100

    tests: add minmal matroskademux test for subtitle output

    Some of the subtitle chunks will have embedded
    NUL-terminators (last three), some don't (first three),
    some will have markup, some won't, some will be valid
    UTF-8 (all but last), some won't (last stanza).

    https://bugzilla.gnome.org/show_bug.cgi?id=752421

commit 744167056cea37fd6b225416624ff84bbb130b8f
Author: Dimitrios Christidis <dchristidis at mykolab.com>
Date:   Thu Jul 16 18:49:26 2015 +0300

    matroskademux: fix for subtitle buffers with NUL terminators

    Commit 45892ec8 created a regression where g_utf8_validate() would fail
    if the subtitle buffer had a NUL terminator as part of the data.

    https://bugzilla.gnome.org/show_bug.cgi?id=752421



I agree that jumping through hoops to NUL-terminate the data just in case some
other element is buggy is a bit over the top, so let's not do that and just
trim off an existing terminator.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.