[Bug 752758] validate: descriptor-writer: Print proper error message when discover fails

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752758

--- Comment #6 from Vineeth <vineeth.tm at samsung.com> ---
In case of (In reply to Thibault Saunier from comment #4)
> Review of attachment 307963 [details] [review]:
> 
> ::: validate/gst/validate/media-descriptor-writer.c
> @@ -534,1 +531,2 @@
>      goto out;
> +  } else {
> 
> Why would the first condition not be met?
> 
> @@ -535,0 +532,21 @@
> +  } else {
> +    GstDiscovererResult result = gst_discoverer_info_get_result (info);
> +    switch (result) {
> ... 18 more ...
> 
> Than one is indeed pretty usefull :)

For some files, i don't have plugins installed.
So it will throw GST_DISCOVERER_MISSING_PLUGINS. But in this case, info is not
NULL and gst_discoverer_discover_uri doesn't throw any error.
Only on result = gst_discoverer_info_get_result (info), i get an error.
So i checked how gst-discoverer is handling this and added the code here.




(In reply to Thibault Saunier from comment #5)
> Review of attachment 307970 [details] [review]:
> 
> How would that happen? If there is no stream info it means the discovering
> failed no?

It was able to get the discoverer info and was not failing with any error. But
there was no stream info and since there was no check, it was throwing an
assertion error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.