[Bug 748377] OpenCV face detection does not work with OpenCV newer than 2.4.10
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Jul 23 03:53:32 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=748377
Tim-Philipp Müller <t.i.m at zen.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |t.i.m at zen.co.uk
--- Comment #17 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Nice, thanks for working on this!
Didn't review in depth, but looks fine overall.
Some small style nitpicks:
- the two commits (rename plus change code to C++) should be squashed into one
- the bug number (ideally the whole bugzilla bug url) should go into the
commit message at the bottom, but not into the summary line
- the code should ideally still be indented with GStreamer indentation style.
Not sure if running gst-indent on the .cpp file will just work, maybe just try
it. Otherwise not so important, can be fixed later.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list