[Bug 752800] New: basetransform: may return not-negotiation on shutdown

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752800

            Bug ID: 752800
           Summary: basetransform: may return not-negotiation on shutdown
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Normal
         Component: orc
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: olivier.crete at ocrete.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
                CC: ds at schleef.org
     GNOME version: ---

Created attachment 308039
  --> https://bugzilla.gnome.org/attachment.cgi?id=308039&action=edit
basetransform: Return FLOW_FLUSHING if negotiation fails during shutdown

There is a race in basetransform, where, if setcaps is called from
default_submit_input_buffer() while it is shutting down, the setcaps may fail
because the srcpad has already been set to flushing, this will then "goto
not_negotiated" and return flow-not-negotiated , instead of flow-flushing.

Possible (not so nice) patch is attached.

I can reproduce it quite reliably with
validate.file.playback.change_state_intensive.raw_video_mkv:

GST_GL_XINITTHREADS=1 DISPLAY=:1 GST_VALIDATE_SCENARIO=change_state_intensive
gst-validate-1.0  playbin
uri=file:///home/ocrete/gst-validate/gst-integration-testsuites/medias/defaults/matroska/raw_video.mkv
audio-sink='fakesink sync=true' video-sink='fakesink sync=true'
--set-media-info
"/home/ocrete/gst-validate/gst-integration-testsuites/medias/defaults/matroska/raw_video.mkv.media_info"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.