[Bug 752743] gl: add support for egl+x11+swrast on osx

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752743

--- Comment #10 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Matthew Waters from comment #6)
> Review of attachment 307935 [details] [review]:
> 
> If you're doing funky stuff like loading mesa on OSX, you can always pass
> the opengl library's to configure and it will use them instead.
> 
> ::: configure.ac
> @@ +761,3 @@
> +  *-*darwin*)
> +    GL_CFLAGS="-Wno-typedef-redefinition"
> +    GL_OBJCFLAGS=$GL_CFLAGS
> 
> Not a fan of globally disabling the typedef redefinition warning on OS X.

Right, I'll add it only if darwin+egl

> 
> @@ +1035,3 @@
>        fi
> +
> +      if test "x$NEED_EGL" != "xno"; then
> 
> Also need to test that $HAVE_EGL is "yes" as well.

Right.

> 
> ::: gst-libs/gst/gl/gstglcontext.c
> @@ +124,3 @@
> +#ifdef __APPLE__
> +  if (!module_opengl && (_get_default_gl_platform () ==
> GST_GL_PLATFORM_GLX))
> +    module_opengl = g_module_open ("libGL.1.dylib", G_MODULE_BIND_LAZY);
> 
> Don't we -framework OpenGL which links against libGL.dylib?  Thus, the
> g_module_open (NULL) will find the opengl functions anyway later?  Or am i
> misunderstanding how -framework works?  Also, what's happening with the link
> command when including glx and cgl? Aren't two GL libraries being linked in?
> Or is the mesa code linked against libGL.dylib as well?  This all sounds
> like a recipe for disaster honestly.

You are right, this line does not make sense and also glx already work without
it. 
It should be GST_GL_PLATFORM_EGL, not GST_GL_PLATFORM_GLX. Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.