[Bug 752743] gl: add support for egl+x11+swrast on osx

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752743

--- Comment #12 from Matthew Waters <ystreet00 at gmail.com> ---
(In reply to Julien Isorce from comment #9)
> (In reply to Matthew Waters from comment #7)
> > Review of attachment 307934 [details] [review] [review]:
> > 
> > This will now only try one context_new() before failing completely.
> 
> I think it is even better to do so :) gst_gl_context_cocoa_new,
> gst_gl_context_egl_new etc ... should not fail really otherwise something
> really wrong happened and we should not try to create another type of
> context (because these functions only allocate the object if I am not
> mistaken). Also if a specific block is built we expect it to work.
> But maybe I am missing something ?

That's not how I see it.  Context specific _new() implementations should fail
for example, if it cannot work with the GstGLDisplay type.  While that's
against the guidelines of _new() operation, gst_gl_context_new is a bit special
in that it's just a selector for choosing an appropriate context
implementation.  Currently the implementations  do not fail and you can very
easily get into situations where you're trying to create a glx context on
wayland without overriding with all of GST_GL_PLATFORM, GST_GL_WINDOW,
GST_GL_API env variables.  The other case where this would be useful is with
application provided GstGLDisplay's for the same reason without having to
explicitly override GstGLDisplay::create-context.  The defaults should just
work™.

In your case the same is true, if you only supply GST_GL_WINDOW=x11 on OS X but
don't provide GST_GL_PLATFORM, it will attempt to create a CGL context with a
X11 display handle and/or create an x11 window which isn't going to work very
well.

Same for x11/wayland + glx/egl.
You can probably also install mesa on win32 and have the same problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.