[Bug 752743] gl: add support for egl+x11+swrast on osx

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752743

--- Comment #20 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Julien Isorce from comment #17)
> (In reply to Matthew Waters from comment #13)
> > ::: gst-libs/gst/gl/gstglcontext.c
> > @@ +124,3 @@
> > +#ifdef __APPLE__
> > +  if (!module_opengl && (_get_default_gl_platform () ==
> > GST_GL_PLATFORM_EGL))
> > +    module_opengl = g_module_open ("libGL.dylib", G_MODULE_BIND_LAZY);
> > 
> > You should probably remove the && _get_default_gl_platform() == to always
> > get the dylib on OS X.  The g_module_open call below is targetted to
> > loadable modules which OS X differentiates between that and shared
> > libraries.  See
> > http://www.finkproject.org/doc/porting/porting.en.html#shared.lib-and-mod
> 
> Ah ok I'll try it
If I remove the "&& _get_default_gl_platform() =="
then when using cgl it fails with:
ERROR: from element
/GstPipeline:pipeline0/GstGLImageSinkBin:glimagesinkbin0/GstGLImageSink:sink:
glGetString not defined or returned invalid value

Maybe it would be better to have gstglcontext in this function to get its
platform.
It would require to change api of gst_gl_context_default_get_proc_address to
pass the gstglcontext pointer or its platform. Not sure how exactly yet because
of gst_gl_context_get_proc_address_with_platform deps.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.