[Bug 748439] vtdec: strange error handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748439

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302442|none                        |reviewed
             status|                            |

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 302442:
 --> (https://bugzilla.gnome.org/review?bug=748439&attachment=302442)

::: sys/applemedia/vtdec.c
@@ -383,3 @@
       VTDecompressionSessionDecodeFrame (vtdec->session, cm_sample_buffer,
       input_flags, frame, NULL);
-  if (status != noErr && FALSE)

Indeed, that was strange, I wonder who reviewed Alessandro's patches ...

@@ +395,3 @@
 error:
+  GST_VIDEO_DECODER_ERROR (vtdec, 1, STREAM, DECODE, (NULL),
+      ("VTDecompressionSessionDecodeFrame returned %d", (int) status), ret);

Don't we need to also call gst_video_decoder_drop_frame(), otherwise if this is
not the maximum error count, we'll endup leaking this frame in the decoder
frame list no ? (I might be missing context with just the diff here, let me
know).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.