[Bug 749260] disparity: Add a "max-disparity" property

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jul 27 07:42:54 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=749260

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303253|none                        |needs-work
             status|                            |

--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 303253:
 --> (https://bugzilla.gnome.org/review?bug=749260&attachment=303253)

Please submit a patch with git-format patch format, this patch has no author or
commit message information.

::: ext/opencv/gstdisparity.cpp
@@ +152,2 @@
 #define DEFAULT_METHOD METHOD_SGBM
+#define DEFAULT_MAX_DISPARITY 16

What is the drawback for the algorithms that had a default of 32/64 when they
receive 16 now?

Perhaps having -1 as an 'auto' and keeping the old values for these cases would
prevent breaking applications relying on this?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list