[Bug 752415] dashdemux: provide a default suggestedPresentationDelay

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752415

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307468|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 307468:
 --> (https://bugzilla.gnome.org/review?bug=752415&attachment=307468)

::: ext/dash/gstdashdemux.c
@@ +188,3 @@
 #define DEFAULT_BANDWIDTH_USAGE         0.8     /* 0 to 1     */
 #define DEFAULT_MAX_BITRATE        24000000     /* in bit/s  */
+#define DEFAULT_PRESENTATION_DELAY       12     /* in seconds */

This seems rather arbitrary. I'd prefer having it as 0 as default to just go to
the current time rather than being 12s behind.
Another option is try to base on the fragment durations, like going 1 fragment
behind or 3 (like HLS does).

Also, how is the application supposed to know what value to use here? Maybe
just having a better heuristic would be enough or do you have an use case where
the application actually suggest a value?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.