[Bug 752613] qtdemux: unsigned raw 16 bit PCM audio not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752613

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308194|none                        |needs-work
             status|                            |

--- Comment #24 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 308194
  --> https://bugzilla.gnome.org/attachment.cgi?id=308194
This is the diff-patch after modification

commit e6381ef285ca6e0c909b1ad6cba6183fe1ac435d
This patch still has some problems:

1) qtdemux.c: In function 'qtdemux_parse_tree':
    error: 'depth' may be used uninitialized in this function:
       format = gst_audio_format_build_integer (TRUE, endian, depth, depth);

2) the indentation was not right, please run gst-indent on the .c file in
future.

I have fixed these now and pushed this:

Author: Manasa Athreya <manasa.athreya at lge.com>
Date:   Mon Jul 27 13:34:14 2015 +0900

    qtdemux: fix 16-bit PCM audio advertised with 'raw ' fourcc

    'NONE' and 'raw ' fourcc don't always contain U8 audio, it can
    be more bits as well, in which case it's just like 'twos'.

    https://bugzilla.gnome.org/show_bug.cgi?id=752613


I'm not sure why you are talking about 'unsigned 16-bit PCM' in your commit
message, it seems to be signed 16-bit PCM.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.