[Bug 748738] gstevent: add new api for parse seek event
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jul 28 07:59:03 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=748738
Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #303928|none |needs-work
status| |
--- Comment #11 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 303928:
--> (https://bugzilla.gnome.org/review?bug=748738&attachment=303928)
There is quite a big type error, that makes me think it should not be
considered for 1.6. Remains I've made a review as if it was. Additional, you
forgot to update the -sections.txt file in docs, and forgot to update win32
definition file (warning in make check, error in make distcheck).
::: gst/gstevent.c
@@ +1211,3 @@
+ *
+ * Allocate a new seek event with the given @segment
+ * Returns: (transfer full): a new seek event.
Missing Since 1.6 mark
@@ +1243,3 @@
+ GST_QUARK (RATE), G_TYPE_DOUBLE, segment->rate,
+ GST_QUARK (FORMAT), GST_TYPE_FORMAT, segment->format,
+ GST_QUARK (FLAGS), GST_TYPE_SEEK_FLAGS, segment->flags,
Segment flags are not of GST_TYPE_SEEK_FLAGS, this need conversion. It might
not be reversible.
@@ +1258,3 @@
+ * @segment: a pointer to a #GstSegment
+ *
+ * Parses a seek @event and stores the retults in the given by @segment.
Missing Since 1.6 mark.
::: gst/gstsegment.h
@@ +210,3 @@
+ GstSeekType start_type;
+ GstSeekType stop_type;
+ } seek;
Everywhere else we use ABI.abi.
::: tests/check/gst/gstevent.c
@@ +219,3 @@
+ fail_if (GST_EVENT_IS_SERIALIZED (event));
+
+ gst_event_parse_seek_segment (event, &parsed);
parsed looks too much like a boolean. Could be name parsed_segment ?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list