[Bug 753001] New: NULL GstBuffer pointer being passed within gst_rtp_buffer_set_extension_data

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753001

            Bug ID: 753001
           Summary: NULL GstBuffer pointer being passed within
                    gst_rtp_buffer_set_extension_data
    Classification: Platform
           Product: GStreamer
           Version: 1.x
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: brianfpeters at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In the function ensure_buffers (called by gst_rtp_buffer_set_extension_data) in
gstrtpbuffer.c in the 'if(changed)' scope at the end of the function
gst_rtp_buffer_unmap is called. This function sets the buffer pointer in its
argument to NULL. The next two lines in ensure_buffers use this pointer in
calls to gst_buffer_remove_memory_range and gst_rtp_buffer_map.

This was discovered in version 1.2.4 working on SLES12 but appears to be
present in further versions as well.

A possible fix is the following (lines numbers as per
gst-plugins-base-1.2.4/gst-libs/gst/gstrtpbuffer.c):

774a775
>     GstBuffer *pBuffer = rtp->buffer;
776,777c777,778
<     gst_buffer_remove_memory_range (rtp->buffer, pos, -1);
<     gst_rtp_buffer_map (rtp->buffer, GST_MAP_READWRITE, rtp);
---
>     gst_buffer_remove_memory_range (pBuffer, pos, -1);
>     gst_rtp_buffer_map (pBuffer, GST_MAP_READWRITE, rtp);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.