[Bug 752866] souphttpsrc: check null string before setting proxy

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752866

--- Comment #5 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Review of attachment 308211:
 --> (https://bugzilla.gnome.org/review?bug=752866&attachment=308211)

Good catch but:

::: ext/soup/gstsouphttpsrc.c
@@ +2046,3 @@
   if (g_str_has_prefix (uri, "http://")) {
     src->proxy = soup_uri_new (uri);
   } else {

I think it would be better to move the test here
as else if (uri[0] != '\0') { ... } else return FALSE;

Also, it might make sense to extend the test to avoid
setting nonsensical values altogether but that might
be too much, just a thought.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.