[Bug 752962] v4l2videodec: Add resolution change support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752962

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308432|none                        |needs-work
             status|                            |

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308432:
 --> (https://bugzilla.gnome.org/review?bug=752962&attachment=308432)

Only reviewed v4l2_call.c

::: sys/v4l2/v4l2_calls.c
@@ +506,3 @@

+gboolean
+gst_v4l2_subscribe_event (GstV4l2Object * v4l2object)

I'd prefer if you create a helper to register 1 event, not a hidden selection.

@@ +513,3 @@
+  e = v4l2object->element;
+
+  GST_DEBUG_OBJECT (e, "subscribe event");

Drop e, it fits on single line, and it's the only use.

@@ +521,3 @@
+  sub.type = V4L2_EVENT_SOURCE_CHANGE;
+  if (v4l2_ioctl (v4l2object->video_fd, VIDIOC_SUBSCRIBE_EVENT, &sub) < 0)
+    goto failed;

This is not backward compatible. This will post on error on the bus for older
driver. Remember this event it new in the kernel.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.