[Bug 739289] Stepping with Video-only Files not respecting step amount

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739289

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308309|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308309:
 --> (https://bugzilla.gnome.org/review?bug=739289&attachment=308309)

::: libs/gst/base/gstbasesink.c
@@ +3882,3 @@
       sink->need_preroll = FALSE;
+
+      if (GST_STATE (sink) == GST_STATE_PLAYING)

I'm worried about locking here. Also, why isn't this check needed for
_flush_start() ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.