[Bug 752866] souphttpsrc: check null string before setting proxy

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752866

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308431|none                        |needs-work
             status|                            |

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 308431:
 --> (https://bugzilla.gnome.org/review?bug=752866&attachment=308431)

Thanks for updating the patches. There are still 2 minor issues before this
patch can be merged:

1) Your patch changes the file access mode from 644 to 755. I guess this was
added by mistake.
2) After the patch you get a WARNING printed to the debug output when
http_proxy="" saying that it couldn't be parsed. I guess making "" meaning no
proxy shouldn't be considered a warning condition. I proposed considering "" as
a correct input to the proxy and no warning should be printed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.