[Bug 753088] decodebin: fix deadend_details string leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753088

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308508|none                        |needs-work
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 308508:
 --> (https://bugzilla.gnome.org/review?bug=753088&attachment=308508)

There seems to be a typo or some missing word in the commit message.

Is there an easy way to reproduce the leak? I guess it happens when a first try
at linking an element fails but a second element succeeds, so the previous
element errors are still returned.

Would it make sense to have the connect_pad clean up the variable itself in
case the pad is not a deadend? It seems weird to return deadend_details if the
pad is not a deadend.

::: gst/playback/gstdecodebin2.c
@@ +1788,1 @@


g_free already does NULL check internally, you can simply call g_free
(deadend_details) here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.