[Bug 753079] validate: Should not store stream-id in media-info for local files

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jul 31 06:21:59 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753079

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308503|none                        |rejected
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308503:
 --> (https://bugzilla.gnome.org/review?bug=753079&attachment=308503)

This is incorrect solution.

::: validate/gst/validate/media-descriptor.c
@@ +297,3 @@
+    else
+      return -1;
+  }

This changes the test completly. What it was doing is checking that for the
same stream ID we have the same caps, which, for any URI is valid.

@@ +301,2 @@
+  if (!gst_caps_is_equal (rstream->caps, cstream->caps))
+    return 0;

And now you check it but don't set the error/warning message anymore.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list