[Bug 750172] miniobject double WRITE | EXCLUSIVE lock succeeds despite part-miniobject.txt forbidding it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750172

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304320|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304320:
 --> (https://bugzilla.gnome.org/review?bug=750172&attachment=304320)

::: gst/gstminiobject.c
@@ +195,3 @@

+    /* shared counter > 1 and write access is not allowed */
+    if ((state & GST_LOCK_FLAG_WRITE || access_mode & GST_LOCK_FLAG_WRITE)

clang/gcc does not complain here with a warning to add parenthesis? Please add
some around the bitwise AND before pushing :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.