[Bug 749567] tcpclientsrc: add timeout property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749567

--- Comment #2 from Nicola <lists at svrinformatica.it> ---
(In reply to Prashant Gotarne from comment #1)
> Review of attachment 303571 [details] [review]:

thanks for the review!

> 
> I think its better to set the max value of timeout property to G_MAXUINT
> instead of 3600. 

I used 3600 as souphttpsrc (I thought was an accepted value), no problem to
change to G_MAXUINT even if I don't see any pratical use case for a so high
timeout (tcp stack will however timeout after 7200 seconds if you don't change
kernel settings)

> Let's give freedom to user to choose any value from 0 to G_MAXUINT.
> 
> Also adding use case to explain the need of timeout property.
> Run a server on one machine.
> #server-107.108.234.23:
> nc -l -p 3000
> 
> Run following pipeline on another machine
> #client-107.108.234.56:
> gst-launch tcpclientsrc host="107.108.234.23" port=3000 ! fdsink fd=2
> 
> If we pull the network cable from the client machine, it never detects 
> the network failure and keeps waiting for the data from server.
> 
> Setting timeout value can be useful here.

ok, I'll add that, 

probably the patch need a "Since: 1.6" too if you plan to push before 1.6
release, can you please confirm?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.