[Bug 749653] dashdemux: Implement binary search for stream_sidx_seek

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749653

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304302|none                        |needs-work
             status|                            |

--- Comment #14 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 304302:
 --> (https://bugzilla.gnome.org/review?bug=749653&attachment=304302)

::: ext/dash/gstdashdemux.c
@@ +910,3 @@
+  if (entry_ts < *ts)
+    return -1;
+  else if (entry_ts > *ts)

This looks wrong. Shouldn't this second 'if' be:

"else if (entry->pts > *ts)" ?

i.e. "if the timestamp is before the beginning of the entry" as opposed to "if
the timestamp is before the end of the entry".

Another way to look at it is that the last "else" branch (the one that returns
0) will only be reached (with the current code) if "entry_ts == *ts", which is
wrong, it should be reached if "*ts >= entry->pts && *ts < entry_pts +
entry_duration"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.