[Bug 750172] miniobject double WRITE | EXCLUSIVE lock succeeds despite part-miniobject.txt forbidding it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750172

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.1

--- Comment #7 from Matthew Waters <ystreet00 at gmail.com> ---
commit e9c15d53212ff424a047e933ca9ab662ae155b56
Author: Matthew Waters <matthew at centricular.com>
Date:   Tue Jun 2 16:14:50 2015 +1000

    memory: gst_memory_share may fail to exclusively lock the parent memory

    Now that locking exclusively dows not always succeed, we need to signal
    the failure case from gst_memory_init.

    Rather than introducing an API or funcionality change to gst_memory_init,
    workaround by checking exclusivity in the calling code.

    https://bugzilla.gnome.org/show_bug.cgi?id=750172

commit eb71ee40407a4dbd1016c962f8ef36b8d6b4a8b5
Author: Matthew Waters <matthew at centricular.com>
Date:   Tue Jun 2 00:23:37 2015 +1000

    buffer: locking memory exclusively may fail

    Attempt to return a copy of the memory instead.

    https://bugzilla.gnome.org/show_bug.cgi?id=750172

commit ad4569c893e10e0e2dcaab3a076d837ae2bffa35
Author: Matthew Waters <matthew at centricular.com>
Date:   Sun May 31 21:25:23 2015 +1000

    miniobject: disallow a double write/exclusive lock

    gst_memory_lock (mem, WRITE | EXCLUSIVE);
    gst_memory_lock (mem, WRITE | EXCLUSIVE);

    Succeeds when the part-miniobject.txt design doc suggests that this should
fail:

      "A gst_mini_object_lock() can fail when a WRITE lock is requested and
      the exclusive counter is > 1. Indeed a GstMiniObject object with an
      exclusive counter 1 is locked EXCLUSIVELY by at least 2 objects and is
      therefore not writable."

    https://bugzilla.gnome.org/show_bug.cgi?id=750172

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.