[Bug 750325] rtcpbuffer: Update package validation to support reduce size rtcp packets
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jun 3 04:22:26 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=750325
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #304480|none |reviewed
status| |
--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304480:
--> (https://bugzilla.gnome.org/review?bug=750325&attachment=304480)
Looks correct to me, just some typos. I think there was also some code in
rtpsession or rtpsource that assumes that RTCP packets start with SR/RR btw.
::: gst-libs/gst/rtp/gstrtcpbuffer.c
@@ +92,3 @@
* @data: (array length=len): the data to validate
* @len: the length of @data to validate
+ * @allow_reduced_size_rtcp: TRUE if reduce size RTCP package are considered
valid
reduceD
@@ +99,3 @@
* this module.
*
+ * This function is updated to support reduce size rtcp packets according to
reduceD
::: gst-libs/gst/rtp/gstrtcpbuffer.h
@@ +176,3 @@
+ * packets, basically it accepts other types than RR and SR
+ */
+#define GST_RTCP_REDUCE_SIZE_VALID_MASK (0xc000 | 0x2000 | 0xf8)
REDUCED with D in the end :)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list