[Bug 750332] rtpsession: Add support for reduced size rtcp
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jun 3 04:28:15 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=750332
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #304484|none |needs-work
status| |
--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304484:
--> (https://bugzilla.gnome.org/review?bug=750332&attachment=304484)
I don't think this is complete. I remember seeing code in rtpsession or
rtpsource that assumed that RTCP packets start with SR/RR.
Also you probably want to change the commit message to say "Add support for
*receiving* reduced size RTCP" :) However adding support for sending it is also
trivial, just add a property for that and then do some more is_early &&
do_reduced_size checks during RTCP generation. You can make all early RTCP
packets reduced size.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list