[Bug 750325] rtcpbuffer: Update package validation to support reduced size rtcp packets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750325

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304487|none                        |needs-work
             status|                            |

--- Comment #10 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 304487:
 --> (https://bugzilla.gnome.org/review?bug=750325&attachment=304487)

::: gst-libs/gst/rtp/gstrtcpbuffer.h
@@ +229,3 @@

+gboolean        gst_rtcp_buffer_validate_data_full      (guint8 *data, guint
len, gboolean allow_reduced_size_rctp);
+gboolean        gst_rtcp_buffer_validate_full           (GstBuffer *buffer,
gboolean allow_reduced_size_rctp);

Can't you just make it into a
gst_rtsp_buffer_validate_reduced() or something like that. Or if you want ot
make a _full(), make the argument be flags, although I'm not sure what other
flags they could be. Guessing what gst_rtcp_buffer_validate_full (buf, TRUE)
means is non easy without having devhelp opened. Something like
gst_rtsp_buffer_validate_full(buf, GST_RTCP_VALIDATE_ACCEPT_REDUCED) is much
more clear. Although my first option is to just make a function without
arguments or flags.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.