[Bug 749328] hlsdemux: Simplify logic in process_manifest

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749328

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
The tests were failing as it would try to get the minimum bitrate variant but
would get the previous/default one with the new behavior.

It seems to me that just dropping the TODO is enough on this case, after the
connection-speed logic has been moved to the baseclass there isn't much left to
fix here.

commit 0a63fa7a01e82b00251f1a995d8cf14593d0fbfb
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Fri Jun 5 09:22:58 2015 -0300

    hlsdemux: drop TODO that doesn't need a solution

    Connection speed is only checked at that point in hlsdemux so there
    is no real need to refactor it.

    https://bugzilla.gnome.org/show_bug.cgi?id=749328

commit 581d8c0b8d0c3d7d4261282c8b1555e43deecb6b
Author: Thiago Santos <thiagoss at osg.samsung.com>
Date:   Fri Jun 5 09:15:34 2015 -0300

    Revert "hlsdemux: Simplify logic in process_manifest"

    This reverts commit 4ca3a22b6b33ad8be4383063e76f79c4d346535d.

    The connection-speed=0 is used as a special value in the property
    of hlsdemux to mean 'automatic' selection, m3u8.c doesn't need
    to know about that as it should be as simple as possible.

    So this patch hides this automatic selection documented in hlsdemux
    into m3u8 logic and I think the gets harder to understand the code.

    It also makes the hlsdemux unit tests work again

    https://bugzilla.gnome.org/show_bug.cgi?id=749328

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.