[Bug 742875] [API] new audiovisualizer base class

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742875

--- Comment #26 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Thanks to the changes Luis made, the public api surface is much less. 

A few things we might want to discuss:
guint req_spf;                /* min samples per frame wanted by the subclass
*/

This could also be a property. Then the baseclass could wrap this with code to
do some sanity checks. Although I don't have a good example yet for e.g. what
would be out-of-bounds here.

The 3 vmethods are apparently sufficient for all our visualizers. Anything that
should be changed there?

The shader feature might need more work for some videoformats, e.g.:
gst-launch-1.0 -v audiotestsrc ! goom shader=8 ! videoconvert ! autovideosink

Also for the goom and goo2k1 ports
gst-launch-1.0 -v audiotestsrc ! goom shader=0 ! videoconvert ! autovideosink
gst-launch-1.0 -v audiotestsrc ! goom2k1 shader=0 ! videoconvert !
autovideosink
causes a black screen.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.