[Bug 750566] FTBFS: possible uninitialized variables

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 8 09:34:03 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750566

--- Comment #4 from Luis de Bethencourt <luis at debethencourt.com> ---
Very interesting Chris. Thanks for the build log.

The purpose of chose_a_goom_line() just above the line that Errors is to assign
the values on those variables. Except the assignment of param1 and param2
happen inside switch cases, so there isn't absolute guarantee of it happening.

You don't need to initialize amplitude because this variable is always written.
Coverity will complain about this value being overwritten before being used if
you initialize it.

I think a better way to fix this is in that function. See patch attached and
let me know if it works well for you.

Thanks for spotting this! :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list