[Bug 738687] midi: add alsamidisrc, an ALSA MIDI sequencer source
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jun 9 15:04:16 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=738687
Antonio Ospite <ao2 at ao2.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #288752|needs-work |none
status| |
Attachment #288752|0 |1
is obsolete| |
--- Comment #2 from Antonio Ospite <ao2 at ao2.it> ---
Created attachment 304902
--> https://bugzilla.gnome.org/attachment.cgi?id=304902&action=edit
midi: add an ALSA MIDI sequencer source v2
Hi, here is a v2 of the patch, I addressed all the comments in the review
(thanks Stefan, BTW) and added some other cleanups.
Changes since v1:
- Fix some typos in the documentation
- Improve wording in the documentation
- Remove the finalize() vmethod, there are no resources to free
- Use g_memdup() instead of g_malloc()+memcpy()
- Use Glib for memory management: g_strdup() g_realloc(), g_malloc(),
g_free()
- Use the _OBJECT variants of GST_ERROR, GST_WARNING and GST_DEBUG
- Define GST_CAT_DEFAULT before calling GST_{ERROR,WARNING,DEBUG}_OBJECT
- Remove the "dump" property and use GST_MEMDUMP_OBJECT()
- Do not set ret = -ENOMEM in gst_alsa_midi_src_start() as it won't be used
- Clarify where the midi tick message 0xf9 comes from
- Improve the comments about the gst_pad_push_list() hack
- Do not use alloca(), the memory is going to be used after the return
- Reorder the cleanup sequence in gst_alsa_midi_src_stop()
- Simplify parse_ports() by using g_strsplit() instead of strchr()
- Do not include "stdlib.h" and "string.h" anymore, they are not needed
- Rename labels starting with err_ to use the error_ prefix, for consistency
- Rename error_free_ports labels to the more descriptive error_free_seq_ports
Please let me know if you test it.
I would still like some comments about the choice of DEFAULT_POLL_TIMEOUT_MS,
and the usage of a GstBufferList in gst_alsa_midi_src_create().
Thanks,
Antonio
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list