[Bug 750788] videofilters: Support for unsharp filter

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750788

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305068:
 --> (https://bugzilla.gnome.org/review?bug=750788&attachment=305068)

Is this just a blur filter? The matrix looks like guassian blur or similar.
Maybe name it like that then, and maybe also add some property to switch
between different blur matrices.

::: gst/videofilters/gstunsharp.c
@@ +51,3 @@
+#define gst_video_unsharp_filter_parent_class parent_class
+G_DEFINE_TYPE (GstVideoUnsharpFilter, gst_video_unsharp_filter,
+    GST_TYPE_VIDEO_BASE_CONVOLVE_FILTER);

I would call the type GstVideoBaseConvolutionFilter, not Convolve

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.