[Bug 740575] Fixing DTS in GStreamer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740575

--- Comment #91 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304898:
 --> (https://bugzilla.gnome.org/review?bug=740575&attachment=304898)

::: gst/isomp4/gstqtmux.c
@@ +3173,3 @@
+ * MP4 however, thus we need to offset DTS so that it starts from 0.
+ * We can leave PTS unchanged, because negative CTTS are valid in MP4.
+ */

Ok, that comment explains the story about negative CTTS.

It's a mistake here to assume that PTS can be smaller then DTS. If this was the
case, we'd have a bug upstream, or the packet is terribly late (QT is not a
streaming format, so that last sentence does not apply). I'll remove that
comment, since it make no sense, and will add a fence for that case. Because
PTS >= DTS, offsetting TS to make it positive will also ensure that PTS is
positive (we shift both).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.