[Bug 750761] inputselector: Handle different duration track selection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750761

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to kevin from comment #21)
> (In reply to Sebastian Dröge (slomo) from comment #18)
> > Review of attachment 305125 [details] [review] [review]:
> > 
> > ::: gst/gstpad.c
> > @@ +4829,3 @@
> > +    GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_EOS);
> > +    remove_event_by_type (pad, GST_EVENT_EOS);
> > +    GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_EOS);
> > 
> > Why remove the flag twice? :) Please update the patch to only do it once,
> > and also add the GST_LOG_OBJECT() from the other places here
> > 
> Ok.
> > And shouldn't the code in push_event/send_event already have done this?
> store_sticky_event () will check the EOS flag and return without push_event.

Good point! I'll push this patch if you change the other part :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.