[Bug 750761] inputselector: Handle different duration track selection

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 12 16:59:53 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750761

--- Comment #25 from kevin <kevinbing.song at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #24)
> (In reply to kevin from comment #22)
> > (In reply to Sebastian Dröge (slomo) from comment #19)
> > > Review of attachment 305127 [details] [review] [review] [review]:
> > > 
> > > ::: plugins/elements/gstinputselector.c
> > > @@ +114,2 @@
> > >  #define DEFAULT_SYNC_STREAMS TRUE
> > > +#define DEFAULT_SYNC_MODE GST_INPUT_SELECTOR_SYNC_MODE_CLOCK
> > > 
> > > Don't change the default, it doesn't generally make sense to use the clock
> > > sync mode
> > > 
> > Ok, still need consider how to handle this. we shouldn't block all input
> > buffer when EOS, the reason is upstream will buffer too many data in
> > streaming case.
> 
> Well, what else would you do? The clock is not even necessarily running
> anymore after EOS was received by the sink.
Sink shouldn't receive EOS until all track reach EOS as streamsynchronizer will
send GAP event to sink.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list