[Bug 749417] rtsp-client: add API to allow application to decide what requirements are supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749417

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305107|none                        |needs-work
             status|                            |

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 305107
  --> https://bugzilla.gnome.org/attachment.cgi?id=305107
rtsp-client: allow application to decide what requirements are supported

>-  /* for now we don't commit to supporting anything, so will just report
>-   * all of the required options as unsupported */
>-  *unsupported_reqs = g_strjoinv (", ", (gchar **) arr->pdata);
>+  g_signal_emit (ctx->client,
>+      gst_rtsp_client_signals[SIGNAL_CHECK_REQUIREMENTS], 0, arr,
>+      &check_result);
>+
>+  if (!check_result) {
>+    /* for now we don't commit to supporting anything, so will just report
>+     * all of the required options as unsupported */
>+    *unsupported_reqs = g_strjoinv (", ", (gchar **) arr->pdata);
>+  }

This doesn't really seem right or complete to me: the application may support
some requirements but not others. The server is supposed to return which
requirements are unsupported, but it can't because it doesn't know.

In the header file Class structure you have to reduce the padding by 1.

I'd rather add this functionality in response to someone actually using it to
make sure it works properly..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.