[Bug 748497] spandsp: Fails to build, uses a private field missing_samples

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748497

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Let's close this. I think the current code is good as it is, and the
risk/benefit ratio of changing it as suggested seems high.

Seeing that accessing that private member is only an optimisation *and* we
don't even know for sure if it's a legit optimisation/assumption to make, we
should probably just leave it as is. Besides, the performance impact of
gst_buffer_make_writable() is tiny, and skipping it is wrong anyway if we map
with READWRITE (what we should've done instead is to map as READ only I guess).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.