[Bug 750965] rtpjitterbuffer : 1. Fix a typing error of comment. 2. Add null check in free_item function.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750965

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305268|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305268:
 --> (https://bugzilla.gnome.org/review?bug=750965&attachment=305268)

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +900,3 @@
 free_item (RTPJitterBufferItem * item)
 {
+  if (item && item->data && item->type != ITEM_TYPE_QUERY)

How can it ever be called with item==NULL? Do you have a testcase for this, or
an description of how it could get here?

Also the g_slice_free() below would still crash then. This function here
shouldn't really be called with NULL at all :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.