[Bug 751000] oggdemux: crash with validate.http.media_check.vorbis_theora_1_ogg

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 15 17:36:35 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751000

Vineeth <vineeth.tm at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305304|none                        |needs-work
             status|                            |

--- Comment #3 from Vineeth <vineeth.tm at samsung.com> ---
Review of attachment 305304:
 --> (https://bugzilla.gnome.org/review?bug=751000&attachment=305304)

I guess it would make more sense to add ogg->building_chain = NULL; in the
function 
gst_ogg_demux_deactivate_current_chain()

where the current chain is being deactivated.

  GstOggChain *chain = ogg->current_chain;

  if (!ogg->pullmode) {
    gst_ogg_chain_free (chain);
  }


So the change can be something like
  if (!ogg->pullmode) {
    gst_ogg_chain_free (chain);
    ogg->current_chain = NULL;
  }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list