[Bug 751027] validateelements: removed redundant test cases and covered more elements
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jun 16 01:05:40 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751027
Thibault Saunier <tsaunier at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #305365|none |needs-work
status| |
--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 305365:
--> (https://bugzilla.gnome.org/review?bug=751027&attachment=305365)
Thanks for the patch.
Also please make sure you code is pep8 complient, I have noticed some little
issues here and there.
::: testsuites/validateelements.py
@@ +35,3 @@
GObject.TYPE_UINT, GObject.TYPE_UINT64,
GObject.TYPE_LONG, GObject.TYPE_ULONG,
+ GObject.TYPE_DOUBLE, GObject.TYPE_FLOAT]
That change is unrelated, please make another commit.
@@ -104,2 +90,3 @@
("validate.launch_pipeline.glfilterbin*",
"glfilter bin doesnt launch."),
+ ("validate.launch_pipeline.glmosaic*",
This is completely unrelated afaict. Please try to open bug reports when it is
a bug, or be more specific about why it is not working (if it is normal it does
not work).
@@ +176,3 @@
+ if test_count > 0:
+ element_count = element_count + 1
+ #print "Element %20s TestCases: %2d" % (fname, test_count)
Please remove that line.
@@ +178,3 @@
+ #print "Element %20s TestCases: %2d" % (fname, test_count)
+
+ print "Total %4d testcases generated for %4d elements" %
(total_test_cases,element_count)
And that one too.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list